Skip to content

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Oct 7, 2018

@geoffw0 geoffw0 added the C++ label Oct 7, 2018
@geoffw0
Copy link
Contributor Author

geoffw0 commented Oct 8, 2018

Fixed merge conflict and added a change note for #264 (external contribution).

@@ -6,14 +6,16 @@

| **Query** | **Tags** | **Purpose** |
|-----------------------------|-----------|--------------------------------------------------------------------|
| *@name of query (Query ID)* | *Tags* |*Aim of the new query and whether it is enabled by default or not* |
| Cast from char* to wchar_t* | security, external/cwe/cwe-704, external/microsoft/c/c6276 | Detects potentially dangerous casts from char* to wchar_t*. Enabled by default on LGTM. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we want those "external/microsoft" tags in this file? I left them out of #235 because I thought they were of too narrow interest and too numerous (one query had 5 of them).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think it's worth mentioning here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jbj jbj merged commit 0e25649 into github:master Oct 9, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Fix 'unused borrow that must be used' warnings.
smowton pushed a commit to smowton/codeql that referenced this pull request Apr 16, 2022
Fix (generic) type access extraction for lambdas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants