Python: Model outgoing HTTP client requests #2904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusWL
force-pushed
the
python-http-clients
branch
from
a976a07 to
d268cbc
Compare
tausbn
requested changes
Feb 25, 2020
| call_origin.getObject().pointsTo(_, constructor_call_value, constructor_call) and | ||
| cls = constructor_call_value.getClass() and | ||
| constructor_call = cls.getACall() | ||
| ) |
There was a problem hiding this comment.
🤔 This looks quite complicated. It's not immediately clear to be why the last two lines are needed. Do you get spurious instances if you omit those lines?
There was a problem hiding this comment.
Yes. I should have left a comment in there explaining why I needed to do that.
Taus poitned out that the reuqest being send off, doesn't *need* to happen on a CallNode. Someone *could* use a __setattr__ or property :\
Move the stdlib tests from test/{2,3}/library-tests/ into /test/library-tests/,
and deal with version by using sys.version_info (results should be the same for
both versions).
six tests were moved from /library-tests/web/client/stdlib => /library-tests/web/client/six
RasmusWL
force-pushed
the
python-http-clients
branch
from
d517aca to
4330d4e
Compare
tausbn
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a great starting point for modeling outgoing HTTP client requests. I wouldn't say it's perfect, but it should be good enough to get me going for the SSRF query I'm trying to get finished 😄