Skip to content

Java: Add some more taint-getter-setter tests. #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Java: Add some more taint-getter-setter tests. #2927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions java/ql/test/library-tests/dataflow/taintgettersetter/A.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,38 @@ void foo(Box b1, Box b2) {
Box b4 = Box.mk(taint());
sink(b4.getS1());
}

static class Box2 {
String s;
String getS() { return s; }
void setS(String s) { this.s = s; }

Box2(String s) {
setS(s + "1");
}
String getS1() { return getS() + "2"; }
String getS2() { return step(getS() + "_") + "2"; }
void setS1(String s) { setS("3" + s); }
void setS2(String s) { setS("3" + step("_" + s)); }
static Box2 mk(String s) {
Box2 b = new Box2("");
b.setS(step(s));
return b;
}
}

void foo2(Box2 b1, Box2 b2) {
b1.setS1(taint());
sink(b1.getS1());

b2.setS2(taint());
sink(b2.getS2());

String t3 = taint();
Box2 b3 = new Box2(step(t3));
sink(b3.s);

Box2 b4 = Box2.mk(taint());
sink(b4.getS1());
}
}
4 changes: 4 additions & 0 deletions java/ql/test/library-tests/dataflow/taintgettersetter/taintgettersetter.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
| A.java:27:14:27:20 | taint(...) | A.java:28:10:28:19 | getS2(...) |
| A.java:30:17:30:23 | taint(...) | A.java:32:10:32:13 | b3.s |
| A.java:34:21:34:27 | taint(...) | A.java:35:10:35:19 | getS1(...) |
| A.java:58:14:58:20 | taint(...) | A.java:59:10:59:19 | getS1(...) |
| A.java:61:14:61:20 | taint(...) | A.java:62:10:62:19 | getS2(...) |
| A.java:64:17:64:23 | taint(...) | A.java:66:10:66:13 | b3.s |
| A.java:68:23:68:29 | taint(...) | A.java:69:10:69:19 | getS1(...) |