Skip to content

Python: Add example of re.compile missing points-to #2932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

RasmusWL
Copy link
Member

@tausbn do you like the idea of having a regressions folder? or should I move them somewhere else?

@RasmusWL RasmusWL requested a review from a team as a code owner February 27, 2020 15:17
@tausbn
Copy link
Contributor

tausbn commented Feb 27, 2020

Hm. The name "regressions" strikes me as slightly odd in this case:

  • Do we know that this ever worked? If not, it's not really a regression.
  • Would we move tests out of the directory once they start yielding the correct results?

I think the idea of having a specific place to put points-to failures is sound, though.

Also, I wonder if this might be fixed by #2915 (probably not, as re isn't a built-in per se). This does make me wonder if we're missing something similar in the interface between C and Python modules.

@RasmusWL
Copy link
Member Author

Also, I wonder if this might be fixed by #2915 (probably not, as re isn't a built-in per se). This does make me wonder if we're missing something similar in the interface between C and Python modules.

I tried this out, and the change in #2915 did not solve the problem 😐

I wanted to highlight that it's not the call to `urlsplit` that is a problem, so
that's why I inserted a `check` in-between.
@RasmusWL RasmusWL force-pushed the python-re.compile-missing-points-to branch from 8ce7d41 to ee4190e Compare February 28, 2020 12:51
@RasmusWL
Copy link
Member Author

I moved things around as we discussed (and did a nasty force-push, since that still felt like the right thing to do).

I also added an other example I had lying around (oh man, messing up the PR name soo much ☹️ ) -- I tried using #2915 on this as well, but no luck

@RasmusWL RasmusWL requested a review from tausbn March 9, 2020 16:11
@tausbn tausbn merged commit e3160f9 into github:master Mar 10, 2020
@RasmusWL RasmusWL deleted the python-re.compile-missing-points-to branch March 10, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants