Python: ObjectAPI to ValueAPI: IncorrectExceptOrder #2989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusWL
requested changes
Mar 10, 2020
There was a problem hiding this comment.
Autoformat, and it should be good to go.
I would just like to note that while ClassValue.getASuperType() is the same as cls.getABaseType*(), ClassObject.getASuperType() is the same as cls.getABaseType+() -- it's a subtle difference, and doesn't seem to matter in this case, but it's something to look out for!
|
@RasmusWL Autoformatted! |
RasmusWL
requested changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the Exceptions modernization effort.