Skip to content

Conversation

asger-semmle
Copy link
Contributor

I've verified that it flags this vulnerability.

It also flags some false positives in the same project due to the input not being JSON (just a string). I'll use this as a testbed for adding a JSON taint kind. I'll do that in a separate PR.

I haven't full an evaluation as the workers are busy and the change is sort of trivial.

@asger-semmle asger-semmle requested a review from a team as a code owner October 10, 2018 09:54
Copy link

@xiemaisi xiemaisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I agree that performance is unlikely to be an issue.

Trying out taint kinds on this sounds like an excellent idea.

@ghost ghost added the JS label Oct 10, 2018
@semmle-qlci semmle-qlci merged commit 16b29b2 into github:master Oct 12, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Add two 'composite' actions for reusing logic
smowton pushed a commit to smowton/codeql that referenced this pull request Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants