JS: Compute barrier guard dominance after exploratory flow #3000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
added
JS
Awaiting evaluation
|
Evaluation looks ok for tuple counts, but the wall clock time was unusually biased time - I'll do some sanity checks. |
asgerf
force-pushed
the
js/late-barrier-guards
branch
from
0d6c2e5 to
2ef21ea
Compare
asgerf
removed
the
Awaiting evaluation
|
Sanity checks went fine. @erik-krogh can you review this? |
erik-krogh
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Looks good, everything makes sense 👍
I'm was suspicious of that performance evaluation, as both the wall-clock and dpm agreed that performance was generally worse, and only tuple counts showed an improvement.
But your sanity checks worked out, so 👍 from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricts computation of barrier guard dominance and barrier guard functions to those reachable by exploratory flow.
Evaluation on smoke-test shows an improvement of a few percent and (a slightly earlier revision) on nightly is also leaning on positive but is missing a final tweak which I'm evaluating now.
Commit-by-commit review recommended.