C++: Suppress UnsignedGEZero.ql in template instantiations #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It still runs on uninstantiated templates because its underlying libraries do. It's not clear whether that leads to other false positives, but that's independent of the change I'm making here.
geoffw0
approved these changes
Oct 12, 2018
There was a problem hiding this comment.
LGTM.
I think analysing the templates themselves (we sometimes call these 'uninstantiated templates', but I'm not fond of the term) should be OK, as any comparison involving a template parameter would either not be populated at all or not have a type this query understands.
Merged
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Use integer comparisons instead of strings when scanning ERB files
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
Add delegated property tests and adjust extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change as in #276, just for a similar query. Requested in https://discuss.lgtm.com/t/false-alarm-for-unreachable-unsigned-comparison-to-zero/1392.