Skip to content

Python: ObjectAPI to ValueAPI: IterReturnsNonSelf #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BekaValentine
Copy link
Contributor

@BekaValentine BekaValentine commented Mar 10, 2020

This PR is part of the Functions modernization effort.

This PR depends on shared changes with other PRs and probably should be merged in specific orders. TBD

EDIT (2020-04-01): In particular after #3039

@tausbn
Copy link
Contributor

tausbn commented Apr 1, 2020

I think this looks reasonable. I would suggest autoformatting first, and then merging master into this branch. I can tell already now that there will likely be merge conflicts if you do it the other way. 🙂

@BekaValentine BekaValentine marked this pull request as ready for review April 3, 2020 23:46
@BekaValentine BekaValentine requested a review from a team as a code owner April 3, 2020 23:46
@BekaValentine BekaValentine requested review from RasmusWL and removed request for a team April 3, 2020 23:46
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Also great to get getAnInferredReturnType updated 🥇

@RasmusWL RasmusWL merged commit 4ce3d5b into github:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants