Dataflow: Exclude param-param flow through with identical params. #3060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Mar 16, 2020
aschackmull
force-pushed
the
dataflow/no-param-to-same-param-flow
branch
from
f76d6ca to
f29f0f4
Compare
|
Java job looks fine. The other two still failed for some reason. |
hvitved
approved these changes
Apr 1, 2020
|
I looked at CPP-Differences 1001 in the profile viewer and concluded that the Wireshark performance regression was unrelated to this PR. Probably noise. |
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
Apr 1, 2020
|
FTR, here is a successful CSharp-Differences run that shows performance is unchanged: https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/88/. |
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
May 6, 2020
max-schaefer
pushed a commit
to max-schaefer/codeql-go
that referenced
this pull request
May 6, 2020
owen-mc
pushed a commit
to owen-mc/codeql-go
that referenced
this pull request
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a heuristic that we have been generally enforcing (and still enforce elsewhere in the lib), but it was accidentally dropped here in #2631. (Detecting something as a setter that writes a particular argument to a field of itself is unlikely to be real flow).