JS: Don't report TypeScript diagnostics by default #3064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago I made the TypeScript extractor report semantic errors found by the TypeScript compiler, wrongly assuming this would be cheap as the compiler had to compute type information anyway.
For vscode this increased extraction time by ~13% (from 838s to 947s), which I think is a bit much for some diagnostics information.
This hides it behind an internal flag as it's sometimes useful when diagnosing dependency installation.
(The flag name uses the old
SEMMLE_prefix as it's internal anyway).