CPP: Add side effect models for strcpy and strcat. #3089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure is a true positive we lost when we switched to IR-based value numbering. |
Thanks - yes, it looks like a good change and nice surprise! |
|
I'm afraid there's a conflict in test output now. |
|
Merged in master, fixed conflicts (which were limited to the |
|
The tests can be re-triggered and should pass when #3162 is merged. |
jbj
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SideEffectFunctionmodels forstrcpyandstrcat. This turned out not to be important for the issue I was looking at, but we might as well keep the models.