Python: Add fabric command injection support #3111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to add more in a sec, and listing *all* of them in CommandInjection.ql started to be silly
|
Started a differences job to ensure the extra taint tracking isn't degrading performance too much: https://jenkins.internal.semmle.com/job/Changes/job/Python-Differences/29/ |
BekaValentine
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
The code looks good. I think it'd be useful to have a description for the PR for more context, tho. I don't fully know what fabric, etc. is and while I can kind of guess at the intention of the PR, it'd be better to have it written. I don't think that's a must tho.
|
Right, will try to remember 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.