C++/C#: Fix invalid overlap #3112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2020 14:37
…p()` The result of `getDefinitionOverlap()` should never be `MayPartiallyOverlap`, because if that were the case, we should have inserted as `Chi` instruction and hooked the definition up to that instead. There are quite a few existing failures.
`Instruction.getDefinitionOverlap()` depends on `SSAConstruction::getMemoryOperandDefinition()`, which in turn depends on `SSAConstruction::hasMemoryOperandDefinition()`. When the definition in question came from a `Chi` instruction, `hasMemoryOperandDefinition()` incorrectly bound `overlap` to the overlap relationship between the original (non-`Chi`) instruction and the use. The fix is to make use of the `actualDefLocation` parameter to `getDefinitionOrChiInstruction()`, which specifies the location for the result of the `Chi` in that case.
MathiasVP
reviewed
Mar 23, 2020
All changes look like real improvements.
dbartol
added
the
depends on internal PR
|
The only remaining failures are the three SAMATE test failures from the internal repo. I've opened a separate PR there to fix those failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/codeql-c-analysis-team/issues/34
Instruction.getDefinitionOverlap()depends onSSAConstruction::getMemoryOperandDefinition(), which in turn depends onSSAConstruction::hasMemoryOperandDefinition(). When the definition in question came from aChiinstruction,hasMemoryOperandDefinition()incorrectly boundoverlapto the overlap relationship between the original (non-Chi) instruction and the use. The fix is to make use of theactualDefLocationparameter togetDefinitionOrChiInstruction(), which specifies the location for the result of theChiin that case.This PR is easier to review commit-by-commit, so that you can see the new sanity test introduced, along with the original failures it revealed.