C#: Introduce RemoteFlowSink class
#3124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
csharp/dataflow/sources-and-sinks
branch
from
682f0f8 to
95b6f6a
Compare
calumgrant
suggested changes
Apr 1, 2020
csharp/ql/src/semmle/code/csharp/dataflow/flowsources/PublicCallableParameter.qll
Outdated
Show resolved
Hide resolved
calumgrant
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the class
RemoteFlowSinkas an abstraction of any data flow node that can be read by an external user. This currently means:Inner)Textproperties of objects belonging toSystem.Web.UI, that is, possibly implicitly HTML encoded output (which, in particular, is not relevant for the XSS queries).RemoteFlowSinkis used as sinks for the queriescs/sensitive-data-transmissionandcs/information-exposure-through-exception.Note for review: I moved some existing sources and sinks into
security/dataflow/flow{sinks,sources}to keep things consistent, so this PR is best reviewed commit-by-commit.