JavaScript: Fix modelling of exported variables that have definitions without (syntactic) right-hand sides. #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2018 13:00
…t modelling of variable exports.
ghost
added
the
|
Test failure fixed; removing that override was a little reckless. I'll do a another small evaluation to make sure this doesn't mess with performance (but I think it shouldn't). |
xiemaisi
added
WIP
|
Small evaluation on ace and node shows no major performance impact, so I consider this ready to merge (but would of course be happy to do a more extensive evaluation if desired). |
ghost
approved these changes
Oct 16, 2018
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
Adjust trap file names of external file class declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://discuss.lgtm.com/t/false-positive-in-preact/1348.
The actual fix is in the first commit and involves a minor rearrangement so we don't assume
VarDef.getSource()is always defined (because it isn't).Once I had that in,
LocalFunctionstarted acting up with a very expensiveantijoin_rhs. I have no idea why that suddenly became a problem, but the second commit refactors things to fix it.Overall, there is no performance overhead (in fact, the second commit gives us a speedup on some projects), and results are unchanged except for the reported FP in preact, which I'm adding to our default benchmark suite. Given the fact that I wasn't able to find a single other change in results, I think we can skip a change note.