Add code-scanning suites #3163
Merged
Add code-scanning suites #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tausbn
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
I'll be honest, I'm not sure that I am qualified to review this, but for what it's worth, it looks fine to me.
(Also, my apologies for taking so long to review it. Initially, I skipped it since the tests appeared to be failing. Then I looked closer at them and realised the failure was probably transient. Indeed, it went away when I retriggered the tests through QLucie.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the suites that'll be run by default for the code-scanning feature.
Also see github/codeql-go#77 which depends on this.