C++: Test changes for discover_walk #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-semmle
added
C++
depends on internal PR
geoffw0
reviewed
Oct 12, 2018
| @@ -3,5 +3,4 @@ | |||
| | usings.cpp:9:1:9:17 | using namespace N | | |||
| | usings.cpp:18:3:18:13 | using bf | | |||
| | usings.cpp:21:5:21:14 | using gf | | |||
| | usings.cpp:34:3:34:20 | using tbf | | |||
There was a problem hiding this comment.
Any idea what's happened here?
| @@ -100,20 +96,37 @@ isFromUninstantiatedTemplate | |||
| | isfromtemplateinstantiation.cpp:93:55:93:55 | return ... | isfromtemplateinstantiation.cpp:93:7:93:15 | myMethod1 | | |||
| | isfromtemplateinstantiation.cpp:94:7:94:15 | declaration of myMethod2 | isfromtemplateinstantiation.cpp:77:26:77:45 | AnotherTemplateClass<T> | | |||
| | isfromtemplateinstantiation.cpp:94:7:94:15 | declaration of myMethod2 | isfromtemplateinstantiation.cpp:97:25:97:60 | myMethod2 | | |||
| | isfromtemplateinstantiation.cpp:94:7:94:15 | declaration of myMethod2 | isfromtemplateinstantiation.cpp:97:52:97:52 | myMethod2 | | |||
There was a problem hiding this comment.
I'd like @jbj to look at these changes at some point (no need to hold back merging though).
There was a problem hiding this comment.
@ian-semmle and @nickrolfe, have you checked that the test changes in isfromtemplateinstantiation/*.expected are what they should be? These tests are very sensitive to exactly the things you changed in the discover branch, and they contain some of the edge cases that have been problematic in the past.
There was a problem hiding this comment.
The changes look OK to me. There's a new | I | T | row in isfromuninstantiatedtemplate, but that's probably the same issue as the existing rows.
ian-semmle
force-pushed
the
discover_walk
branch
from
8971ef2 to
4e6717b
Compare
ian-semmle
force-pushed
the
discover_walk
branch
from
4e6717b to
ef15523
Compare
nickrolfe
approved these changes
Oct 18, 2018
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Temporarily disable operation call resolution
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
Kotlin: Workarounds for codeql-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.