CPP: Speed up OverflowStatic.ql #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
force-pushed
the
overflowstatic
branch
from
7ef13e7 to
a9b5553
Compare
|
So it turns out the third commit contained a gross logic error (which didn't normally show up in the results of the 'OverflowStatic.ql' query), which was naturally responsible for the speedup on that one. So I've dropped it. |
jonas-semmle
approved these changes
Oct 22, 2018
|
I've just re-triggered Language-Tests/CPP |
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Add a query for uses of `Kernel.open` and `IO.read`
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
Merge upstream main into Kotlin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three separate changes designed to speed up 'OverflowStatic.ql' - though in practice a lot of this stuff is cached so it will speed up the first query to touch it.