C++: Add a user defined swap function to taint tests. #3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to close https://jira.semmle.com/browse/CPP-406, I noticed that a proper test of taint through a user defined swap function was missing.
We still get a false positive in the AST taint tracking (same as for the modelled
std::swap) - which I think I can tolerate - and the IR taint tracking doesn't seem to follow data through the swap at all. @rdmarsh2 can you comment on this perhaps? (I'm not even sure what state the IR taint tracking is supposed to be in)