Skip to content

Python: Fix FN in unused import #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2020
Merged

Python: Fix FN in unused import #3211

merged 2 commits into from
Apr 16, 2020

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Apr 7, 2020 

from unknown import foo, bar
var: Optional['foo'] = None

would not trigger an alert for bar, while the following would.

from unknown import foo, bar
print(foo)

This PR fixes the above inconsistency.

@RasmusWL RasmusWL added the Python label Apr 7, 2020
@RasmusWL RasmusWL requested a review from a team as a code owner April 7, 2020 07:46
@RasmusWL RasmusWL requested review from tausbn and removed request for a team April 7, 2020 07:46
tausbn
tausbn approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This looks ready to merge.

@tausbn tausbn merged commit 964a619 into github:master Apr 16, 2020
@RasmusWL RasmusWL deleted the python-unused-import-small-fix branch April 16, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RasmusWL @tausbn