Skip to content

C++: Replace underscores with dashes in query @id #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

C++: Replace underscores with dashes in query @id #3238

merged 1 commit into from
Apr 9, 2020

Conversation

MathiasVP
Copy link
Contributor

The query id in TlsSettingsMisconfiguration.ql was syntactically invalid. See https://github.slack.com/archives/CP0LHP150/p1586426614314900 for @aibaars comments.

@MathiasVP MathiasVP added the C++ label Apr 9, 2020
@MathiasVP MathiasVP requested a review from a team as a code owner April 9, 2020 10:14
geoffw0
geoffw0 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@geoffw0 geoffw0 merged commit 2f7ec49 into github:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathiasVP @aibaars @geoffw0