Skip to content

Python: ObjectAPI to ValueAPI: IncorrectlyOverriddenMethod #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2020
Merged

Python: ObjectAPI to ValueAPI: IncorrectlyOverriddenMethod #3242

merged 2 commits into from
Apr 24, 2020

Conversation

BekaValentine
Copy link
Contributor

This PR is part of the ValueAPI modernization effort.

@BekaValentine BekaValentine requested a review from a team as a code owner April 9, 2020 21:41
@BekaValentine BekaValentine requested review from RasmusWL and removed request for a team April 9, 2020 21:41
RasmusWL
RasmusWL requested changes Apr 15, 2020
View reviewed changes
@BekaValentine BekaValentine requested a review from RasmusWL April 22, 2020 17:42
RasmusWL
RasmusWL approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@RasmusWL RasmusWL merged commit b2b0296 into github:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusWL RasmusWL RasmusWL approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BekaValentine @RasmusWL