Skip to content

1.24 release: finalize change notes for C# #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2020
Merged

1.24 release: finalize change notes for C# #3284

merged 2 commits into from
Apr 17, 2020

Conversation

felicitymay
Copy link
Contributor

This PR aims to finalize the analysis change notes ready for inclusion with LGTM Enterprise.

The first commit reorders rows in one table.
The second commit makes the following text changes:

  • Add a note about the new option for alert suppression comments (as per Java).
  • Update information on new queries to include availability on LGTM.
  • Combine two changes to one query into a single row.

Please check that I haven't introduced any errors: @Semmle/cs

@felicitymay felicitymay added this to the 1.24 milestone Apr 17, 2020
hvitved
hvitved approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

calumgrant
calumgrant approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calumgrant calumgrant merged commit dbff9b6 into github:rc/1.24 Apr 17, 2020
@felicitymay felicitymay deleted the 1.24/SD-61-CS-finalize-notes branch April 28, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

+1 more reviewer

@calumgrant calumgrant calumgrant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C# documentation
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.
3 participants
@felicitymay @hvitved @calumgrant