CodeQL query to detect OGNL injections #3294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a query to detect OGNL injections. It flags the code where user-provided OGNL expression is evaluated (
getValue
,setValue
andcallMethod
in the below examples):Evaluation of unvalidated expressions can let attacker to modify Java objects' properties or execute arbitrary code.
The tests and required
qlpack.yml
insrc/experimental
andtest/experimental
are also included.