Skip to content

JS: add support for util.inherits in ClassNode #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

JS: add support for util.inherits in ClassNode #3325

merged 1 commit into from
Apr 24, 2020

Conversation

erik-krogh
Copy link
Contributor

Allows us to recognize additional EventEmitters using NodeJSLib::EventEmitterSubClass.

@erik-krogh erik-krogh added the JS label Apr 22, 2020
@erik-krogh erik-krogh requested a review from a team as a code owner April 22, 2020 20:57
asgerf
asgerf reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though some kind of evaluation would be nice

@erik-krogh
Copy link
Contributor Author

Smoke test evaluation was uneventful.

@semmle-qlci semmle-qlci merged commit 28cfe54 into github:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erik-krogh @asgerf @semmle-qlci