Skip to content

C++: Generalize charpred of LibcAssert #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

C++: Generalize charpred of LibcAssert #3330

merged 1 commit into from
Apr 23, 2020

Conversation

MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Apr 23, 2020 •
edited
Loading

Fixes https://github.com/github/codeql-c-analysis-team/issues/54. Turns out we had a similar pattern in the charpred for RecoverableAssert.

@MathiasVP MathiasVP added the C++ label Apr 23, 2020
@MathiasVP MathiasVP requested a review from a team as a code owner April 23, 2020 07:49
jbj
jbj approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests pass.

@jbj jbj merged commit 312e622 into github:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathiasVP @jbj