Python: random modernisations #3348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And we're making things a bit more clean since it's not *any* argument of `open()` that is a taint-sink.
|
Oh, when I went to claim these 2 in https://github.com/github/codeql-python-team/issues/18 I can see that they are actually part of #2677 ... I'm slightly more in favour of the changes to OpenNode in this PR than in https://github.com/Semmle/ql/pull/2677/files#diff-27b7dcc42bc64943dce69f99d4b1aa57L85-L90 though |
|
That's fine by me. We're probably better off just closing the other PR and opening a new one, considering how many changes have happened in the mean time. (It looks to have gone quite stale...) |
|
Nice. I just need you to hit that green approve button then ✔️ 😉 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.