Merge rc/1.24 into master #3377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This predicate is effectively a Cartesian product between all enum types. It's infeasible to compute it in full, so luckily the optimizer has been able to apply enough magic to make it feasible. That's not a robust solution, and it has indeed broken on at least one version of the 1.24 release candidate. On a Chromium snapshot where I ran the LGTM suite overnight, the `m#MistypedFunctionArguments::arithTypesMatch#bb` predicate (magic for `arithTypesMatch`) took 170m5s. That was commit b69fdf5 from the internal repo. I tried to reproduce it in VSCode, this time with commit 646646, but it wasn't quite as bad: the predicate took only 38 seconds. In any case, making the problematic predicate `pragma[inline]` removes the slow magic and makes the `MistypedFunctionArguments.ql` query faster.
It looks like this change will stop `SignedOverflowCheck.ql` from needlessly re-evaluating several cached stages.
C++: Make `Declaration` not abstract
Highlight "unique" as a keyword in CodeQL docs
C++: inline arithTypesMatch predicate
This `select` clause had become very slow after we started caching
`ElementBase::toString` because the query used string concatenation to
produce alert messages, and those string concatenations were done very
early in the pipeline, producing lots of strings that would be discarded
moments later.
By using `$@` to interpolate elements into strings, the concatenation is
done outside of QL.
Testing on a Chromium snapshot, this commit takes us from
#select#ff ................ 6m2s
to
#select#cpe#134#fff ....... 15.2s
C++: Speed up SuspiciousAddWithSizeof select
Learn CodeQL docs: add note about path queries to data flow tutorials
Docs: update outdated links
…k-link Add link to new Go cookbook space
Docs: Update link text
Docs: Delete "Technical information" articles
Approved by shati-patel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.