Skip to content

Conversation

felicitymay
Copy link
Contributor

Following discussions with the docs team and with the language teams, a docs review is necessary only for pull requests for documentation for supported queries and libraries.

This PR updates the CODEOWNERS and supported-queries.md files to reflect this decision.

@jbj - thanks for your suggestion that we update the information on supported queries. I'd forgotten about that.

@mchammer01
Copy link
Contributor

LGTM

@mchammer01 mchammer01 self-requested a review May 5, 2020 12:39
@hubwriter
Copy link
Contributor

hubwriter commented May 5, 2020

I'm not sure how this excludes the docs team. To my way of thinking (but I may be totally wrong about this) the following:

/cpp/**/*.qhelp @hubwriter
...
/cpp/**/experimental/**/*.qhelp @github/codeql-c-analysis

means that @hubwriter becomes the reviewer for all .qhelp files under /cpp and, additionally, @github/codeql-c-analysis is also a reviewer for .qhelp files below the experimental directory.

Ah - having looked this up - I see that these aren't cumulative. A later match overrules a previous one, so in the 2nd match above only the specified group becomes a code owner and hubwriter doesn't for those files. 💡

@felicitymay felicitymay merged commit 0e0d049 into github:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants