C++: Add InBoundsPointerDeref.qll to experimental #3422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m are safe, i.e. in-bounds. It does so by first defining what a pointer dereference is (on the IR `Instruction` level), and then using the array length analysis and the range analysis together to prove that some of these pointer dereferences are safe.
jbj
reviewed
May 7, 2020
rdmarsh2
reviewed
May 7, 2020
cpp/ql/test/experimental/library-tests/rangeanalysis/inboundsptr/test.cpp
Show resolved
Hide resolved
cpp/ql/src/experimental/semmle/code/cpp/rangeanalysis/InBoundsPointerDeref.qll
Outdated
Show resolved
Hide resolved
rdmarsh2
approved these changes
May 13, 2020
cpp/ql/test/experimental/library-tests/rangeanalysis/inboundsptr/test.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library proves that a subset of pointer dereferences in a progam are safe, i.e. in-bounds.
On its own, it is not very useful.
However, it
a) showcases how to use the IR-based RangeAnalysis and the experimental ArrayLengthAnalysis together
b) It can be a starting point to detect out-of-bounds-pointer accesses
c) The analysis can be used as a filter on imprecise (bug-finding) queries that detect potentially OOB memory accesses, to remove false positives.