Skip to content

C++: Remove abstract keyword from Access and Cast classes #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2020
Merged

C++: Remove abstract keyword from Access and Cast classes #3465

merged 3 commits into from
May 15, 2020

Conversation

MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented May 13, 2020 •
edited
Loading

@MathiasVP MathiasVP added C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR labels May 13, 2020
@MathiasVP
Copy link
Contributor Author

MathiasVP commented May 14, 2020 •
edited
Loading

CPP-differences (https://jenkins.internal.semmle.com/job/Changes/job/CPP-Differences/1130/) shows no performance problems.

@MathiasVP MathiasVP marked this pull request as ready for review May 14, 2020 17:44
@MathiasVP MathiasVP requested a review from a team as a code owner May 14, 2020 17:44
@jbj jbj merged commit 8a0af0b into github:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathiasVP @jbj @dbartol