Skip to content

JS: make LocalObjects::isEscape aware of yield #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2020
Merged

JS: make LocalObjects::isEscape aware of yield #3497

merged 1 commit into from
May 19, 2020

Conversation

esbena
Copy link
Contributor

@esbena esbena commented May 18, 2020

@esbena esbena added JS Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish labels May 18, 2020
@esbena esbena requested a review from a team as a code owner May 18, 2020 10:44
asgerf
asgerf reviewed May 18, 2020
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hope the evaluation works out

@esbena
Copy link
Contributor Author

esbena commented May 19, 2020

Permance is neutral and the fixed results are quite good.

@esbena esbena removed the Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish label May 19, 2020
@semmle-qlci semmle-qlci merged commit 0c081a8 into github:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

@erik-krogh erik-krogh erik-krogh approved these changes

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esbena @asgerf @erik-krogh @semmle-qlci