Skip to content

Java: Clean up deprecated overrides. #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020

Conversation

aschackmull
Copy link
Contributor

Adding a warning for override of a deprecated predicate gave the following unique warnings, which should all be fixed by this PR:

[WARN] Overridden predicate getName has been deprecated and may be removed in future (/home/jenkins/workspace/Language-Tests/Java/job/ql/java/ql/src/semmle/code/java/CompilationUnit.qll:15,3-16,65)
[WARN] Overridden predicate getName has been deprecated and may be removed in future (/home/jenkins/workspace/Language-Tests/Java/job/ql/java/ql/src/semmle/code/xml/XML.qll:121,3-122,70)
[WARN] Overridden predicate getTrueSuccessor has been deprecated and may be removed in future (/home/jenkins/workspace/Language-Tests/Java/job/ql/java/ql/src/semmle/code/java/Statement.qll:116,3-120,58)
[WARN] Overridden predicate getTrueSuccessor has been deprecated and may be removed in future (/home/jenkins/workspace/Language-Tests/Java/job/ql/java/ql/src/semmle/code/java/Statement.qll:167,3-171,58)
[WARN] Overridden predicate getTrueSuccessor has been deprecated and may be removed in future (/home/jenkins/workspace/Language-Tests/Java/job/ql/java/ql/src/semmle/code/java/Statement.qll:227,3-231,58)
[WARN] Overridden predicate getTrueSuccessor has been deprecated and may be removed in future (/home/jenkins/workspace/Language-Tests/Java/job/ql/java/ql/src/semmle/code/java/Statement.qll:248,3-252,58)
[WARN] Overridden predicate hasName has been deprecated and may be removed in future (/home/jenkins/workspace/Language-Tests/Java/job/ql/java/ql/src/semmle/code/java/CompilationUnit.qll:18,3-22,74)

The deprecated predicates in FileSystem.qll have been deprecated since before the move to the public repo, so should be fine to delete.

@aschackmull aschackmull requested a review from a team as a code owner May 19, 2020 08:44
@yo-h yo-h merged commit bfeaecc into github:master May 19, 2020
@aschackmull aschackmull deleted the java/cleanup-deprecated-overrides branch May 19, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants