JS: Share implementation between TaintedPath and ZipSlip #3525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
reviewed
May 20, 2020
javascript/ql/src/semmle/javascript/security/dataflow/TaintedPathCustomizations.qll
Outdated
Show resolved
Hide resolved
| DataFlow::Node src, DataFlow::Node dst, DataFlow::FlowLabel srclabel, | ||
| DataFlow::FlowLabel dstlabel | ||
| ) { | ||
| isTaintedPathStep(src, dst, srclabel, dstlabel) |
There was a problem hiding this comment.
Would it make sense to merge these two predicates now? Otherwise, I'd suggest renaming the other one to isPosixPathStep or something like that. Right now the naming and separation is a little weird.
Yes... I meant relative, and both normalized and non-normalized. That is also what the implementation does. |
Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out 2 different strategies for sharing implementation between the TaintedPath and ZipSlip queries.
DataFlow::Configurationwith sources/sinks for both queries, and then select the source/sink in thewhereclause.DataFlow::Configurations.I like 2. the best, and it also turns out that this strategy has the best performance.
The source in ZlipSlip is a relative non-normalized path.
I couldn't find an existing archive with a non-normalized path, but I managed to create a
.tarfile with such a path.An evaluation on nightly looks good.