JS: Remove timeout for node --version check #3531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix https://github.com/github/codeql-javascript-team/issues/120 by disabling the timeout for the call to
node --version
.I was able to verify that the timeout can be triggered if the parent process (Java) is suspended during the interval where
node
is booting up. In a cloud computing environment, my guess is that this suspension happens when the entire VM is paused for some reason, and that the initialnode
call can be slow enough for the pause to occur during that time (e.g. some lazy initialization might happen).The believe the robust solution would be to wrap
node --version
in a retry loop, but I instead decided to just remove the timeout. The timeout seems unnecessary since we afterwards start anode
process without a timeout anyway.