Skip to content

Java: Fix bug in tutorial. #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020

Conversation

aschackmull
Copy link
Contributor

Fixes #3490

shati-patel
shati-patel previously approved these changes May 22, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aschackmull! Would you mind retargetting this against rc/1.24? Then we can publish it next week along with the release.

@aschackmull aschackmull force-pushed the java/tutorial-bug-fix branch from 3ceb765 to 6228e76 Compare May 22, 2020 12:44
@aschackmull aschackmull changed the base branch from master to rc/1.24 May 22, 2020 12:45
@aschackmull
Copy link
Contributor Author

Rebased to the merge-base and retargeted.

Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :shipit:

@shati-patel shati-patel merged commit e990f1b into github:rc/1.24 May 22, 2020
@aschackmull aschackmull deleted the java/tutorial-bug-fix branch May 25, 2020 07:24
Marcono1234 added a commit to Marcono1234/codeql that referenced this pull request Jun 26, 2020
github#3546 changed the query but did not adjust the query link.
Additionally the old query could not be re-run because some of the projects it
targeted (gradle/gradle and eclipse-cdt/cdt) cannot be queried currently.
It now queries all available demo projects of the query console instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java] Question on Overrides of Generic Methods
2 participants