Skip to content

Python: Use proper import for semmle.python.dataflow.TaintTracking #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

Python: Use proper import for semmle.python.dataflow.TaintTracking #3553

merged 1 commit into from
May 25, 2020
+89 −89

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented May 25, 2020 •
edited
Loading

It was moved in 637677d, but imports were not updated.

@RasmusWL
Python: Use proper import for semmle.python.dataflow.TaintTracking
f602f3e 
It was moved in 637677d, but imports were not
updated.
@RasmusWL RasmusWL requested a review from a team as a code owner May 25, 2020 11:47
tausbn
tausbn approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱
How did this ever work? 🤔

@RasmusWL
Copy link
Member Author

Like this 😄

codeql/python/ql/src/semmle/python/security/TaintTracking.qll

Line 3 in bc09720

import semmle.python.dataflow.TaintTracking

@semmle-qlci semmle-qlci merged commit 8146073 into github:master May 25, 2020
@RasmusWL RasmusWL deleted the python-fix-tainttracking-import branch May 25, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn approved these changes

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RasmusWL @tausbn @semmle-qlci