Skip to content

Conversation

jbj
Copy link
Contributor

@jbj jbj commented May 25, 2020

For C++, I took most of the docs from the corresponding predicates in JavaScript's CodeDuplication.qll. Where JavaScript had a corresponding predicate but didn't have QLDoc, I added new QLDoc to both.

I took most of the docs from the corresponding predicates in
JavaScript's `CodeDuplication.qll`. Where JavaScript had a corresponding
predicate but didn't have QLDoc, I added new QLDoc to both.
@jbj jbj requested review from a team as code owners May 25, 2020 17:01
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS LGTM 👍

Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ LGTM!

@MathiasVP MathiasVP merged commit 5fb76df into github:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants