Skip to content

Conversation

MathiasVP
Copy link
Contributor

The current asPartialDefinition for dataflow nodes for the IR doesn't always produce the output one would expect when looking at the AST versions. In particular:

  1. It doesn't always produce a result (even in cases where we expect a result to be produced)
  2. When it produces a result, it returns the expression that defines the partial definition (i.e., the right hand side of a partial definition)

The predicate isn't used very much in our codebase, but it's still nice to be able to track how well the IR is behaving like the AST. This PR:

  1. adds a couple of tests that check whether the partial definitions are present, and the difference between the IR and AST
  2. Fixes the easiest cases so that the IR produces the correct expression corresponding to the partial definition

@MathiasVP MathiasVP added the C++ label May 26, 2020
@MathiasVP MathiasVP requested a review from a team as a code owner May 26, 2020 11:20
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdmarsh2 rdmarsh2 merged commit 593d4c0 into github:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants