Skip to content

C++: Add C++ analysis team to CODEOWNERS #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

jbj
Copy link
Contributor

@jbj jbj commented Oct 24, 2018

We previously removed our entry because the notifications got too noisy, but we agreed recently in the C++ analysis team to try adding an entry with just the analysis team and only in the public repository.

We previously removed our entry because the notifications got too noisy,
but we agreed recently in the C++ analysis team to try adding an entry
with just the analysis team and only in the public repository.
@jbj jbj added the C++ label Oct 24, 2018
@geoffw0
Copy link
Contributor

geoffw0 commented Oct 24, 2018

I'm finding it much easier to track new github pull requests since someone pointed out the #github-ql Slack channel to me. I forget what @dave-bartolomeo and @rdmarsh2 said they'd prefer.

@rdmarsh2
Copy link
Contributor

I'm happy either way.

@dave-bartolomeo
Copy link
Contributor

I think I'd prefer the codeowners file, because the on US time, I mostly see #github-ql as a big list of all the PRs submitted from Europe the night before, rather than an as-it-happens feed of what PRs are being created. It's easier for me to filter email than it is to deal with this in Slack. That said, I would get by just fine just using Slack if that's what everybody else wants.

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds like we should merge this and see how we get on with it.

@geoffw0 geoffw0 merged commit e609a95 into github:master Oct 30, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
smowton pushed a commit to smowton/codeql that referenced this pull request Apr 16, 2022
Add consistency query to verify we always have qualifier for calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants