Skip to content

introduce type unions in the handbook #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 2, 2020
Merged

introduce type unions in the handbook #3572

merged 12 commits into from
Jun 2, 2020

Conversation

ginsbach
Copy link
Contributor

@ginsbach ginsbach requested review from shati-patel and hmakholm May 26, 2020 18:52
@ginsbach ginsbach requested a review from jf205 as a code owner May 26, 2020 18:52
@ginsbach ginsbach requested a review from p0 May 27, 2020 09:06
@shati-patel shati-patel mentioned this pull request May 27, 2020
Merged
@shati-patel
Copy link
Contributor

Thanks for adding this to the docs @ginsbach! The explanations look good to me, but I'll let someone else check the technical details.

I've made some editorial suggestions (mostly to do with style and .rst syntax). I've opened a PR against your branch so I could include a cross-reference to another file (see ginsbach#1).

shati-patel and others added 2 commits May 27, 2020 12:00
hmakholm
hmakholm reviewed May 27, 2020
View reviewed changes
@ginsbach ginsbach requested a review from dbartol May 27, 2020 14:08
p0
p0 previously requested changes May 29, 2020
View reviewed changes
Copy link
Contributor

@p0 p0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested terminology tweaks, but LGTM, especially the examples.

ginsbach and others added 3 commits May 29, 2020 10:21
@ginsbach @p0
restricted _subsets_ of algebraic datatypes
0562b4a 
Co-authored-by: Pavel Avgustinov <54942558+p0@users.noreply.github.com>
@ginsbach @p0
better explanation of the purpose of type unions
299d87a 
Co-authored-by: Pavel Avgustinov <54942558+p0@users.noreply.github.com>
@ginsbach
remove "experimental syntax" box for type unions
bb9e800
hmakholm
hmakholm reviewed May 29, 2020
View reviewed changes
hmakholm
hmakholm reviewed Jun 1, 2020
View reviewed changes
hmakholm
hmakholm previously approved these changes Jun 1, 2020
View reviewed changes
shati-patel
shati-patel previously approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for writing this! I've added one more suggestion, then this looks good to merge.

@shati-patel shati-patel dismissed p0’s stale review June 1, 2020 12:49

Comments addressed

@ginsbach @shati-patel
whitespace in example for type unions fixed
c97055f 
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
@ginsbach ginsbach dismissed stale reviews from shati-patel and hmakholm via c97055f June 1, 2020 13:27
@ginsbach ginsbach merged commit 8b3dd6d into github:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shati-patel shati-patel shati-patel approved these changes

@hmakholm hmakholm hmakholm left review comments

@jf205 jf205 Awaiting requested review from jf205

@dbartol dbartol Awaiting requested review from dbartol

+1 more reviewer

@p0 p0 p0 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ginsbach @shati-patel @hmakholm @p0