Skip to content

C#: Fix performance issue in unification library #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2020
Merged

C#: Fix performance issue in unification library #3574

merged 1 commit into from
May 28, 2020

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented May 27, 2020 •
edited
Loading

This fixes a performance regression introduced on #3351. CSharp-Differences job here.

@hvitved hvitved added the C# label May 27, 2020
@hvitved hvitved requested a review from a team as a code owner May 27, 2020 13:30
calumgrant
calumgrant approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great debugging - and thanks for the offline explanation. (We don't need to handle TupleType as we use the underlying type.)

@calumgrant calumgrant merged commit 725a8f5 into github:master May 28, 2020
@hvitved hvitved deleted the csharp/unification-performance branch May 28, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@calumgrant calumgrant calumgrant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@calumgrant calumgrant

Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @calumgrant