C#: Avoid multiple taint-tracking configurations #3601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The taint-tracking configuration in `ExposureOfPrivateInformation.ql` overlaps with the XSS taint-tracking configuration, as witnessed by this import chain: ``` semmle.code.csharp.security.dataflow.ExposureOfPrivateInformation.qll imports semmle.code.csharp.security.dataflow.flowsinks.ExternalLocationSink imports semmle.code.csharp.security.dataflow.flowsinks.Remote imports semmle.code.csharp.security.dataflow.XSS ``` (The same for `CleartextStorage.qll` and `LogForging.ql`.) The fix is to use `TaintTracking2` for the XSS configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The taint-tracking configuration in
ExposureOfPrivateInformation.qloverlaps with the XSS taint-tracking configuration, as witnessed by this import chain:
(The same for
CleartextStorage.qllandLogForging.ql.)The fix is to use
TaintTracking2for the XSS configuration.