Skip to content

Fix Java code style of MagicConstants examples #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2020
Merged

Fix Java code style of MagicConstants examples #3634

merged 1 commit into from
Jun 8, 2020

Conversation

Marcono1234
Copy link
Contributor

  • Use recommended ordering of modifiers
  • Use recommended variable naming scheme

@Marcono1234
Fix Java code style of MagicConstants examples
ad1146a 
- Use recommended ordering of modifiers
- Use recommended variable naming scheme
@Marcono1234 Marcono1234 requested review from felicitymay and a team as code owners June 6, 2020 23:01
aschackmull
aschackmull approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer, thanks.

@aschackmull aschackmull merged commit e444bcc into github:master Jun 8, 2020
@Marcono1234 Marcono1234 deleted the MagicConstants-code-style branch June 9, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

@felicitymay felicitymay Awaiting requested review from felicitymay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcono1234 @aschackmull