JS: Improve alert message in js/non-linear-pattern

[asgerf]

Improves the alert message in cases where the offending variable looks like a type annotation:

For example:

function distance({x: number, y: number}) {
    return Math.sqrt(x*x + y*y);
}

should actually be:

function distance({x, y}: {x: number, y: number}) {
    return Math.sqrt(x*x + y*y);
}

One could argue this type of alert belongs in IneffectiveParameterType.ql but this isn't a priority.

[erik-krogh]

👍

One could argue this type of alert belongs in IneffectiveParameterType.ql but this isn't a priority.

I think it fits well in NonLinearPattern.ql.

Can you do a small performance test on smoke-tests before merge?

[asgerf]

Evaluation looks fine.