Skip to content

Conversation

esbena
Copy link
Contributor

@esbena esbena commented Jun 22, 2020

I think the comment in the existing qhelp for js/incomplete-sanitization covers this case well enough.

Note, however, that this is generally not sufficient for replacing multi-character strings:
the String.prototype.replace method only performs one pass over the input string,
and will not replace further instances of the string that result from earlier replacements.

@esbena esbena added the JS label Jun 22, 2020
@esbena esbena requested review from mchammer01 and a team as code owners June 22, 2020 12:39
Co-authored-by: Asger F <asgerf@github.com>
@asgerf asgerf merged commit 4a459c8 into github:js-team-sprint Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants