C++: Add QLDocs for Initializer.qll-Macro.qll and model classes #3766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
reviewed
Jun 23, 2020
| @@ -1,3 +1,7 @@ | |||
| /** | |||
| * Proivdes the `LinkTarget` class representing linker invocations at compile time. | |||
There was a problem hiding this comment.
Super nit-picky suggestion: "compile time" -> "build time" or "during the build process", for consistency with the QLDoc below and because strictly speaking linking is usually done after compiling.
| /** | ||
| * Gets a function that includes an expression that is affected by this macro | ||
| * invocation. If the macro expansion includes the end of one function and | ||
| * the beginning of another, this predicate will get both. |
| @@ -1,3 +1,8 @@ | |||
| /** | |||
| * Provides implementation classes modelling `strcat` and various similar functions. | |||
There was a problem hiding this comment.
There's an accidental double space here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.