Skip to content

JS: support member calls of console #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2020
Merged

JS: support member calls of console #3767

merged 1 commit into from
Jun 24, 2020

Conversation

esbena
Copy link
Contributor

@esbena esbena commented Jun 23, 2020

It appears that the members of console are bound by default now, so it seems reasonable to use getAMemberCall instead of getAMethodCall. Thanks #3734.

@esbena esbena added the JS label Jun 23, 2020
@esbena esbena requested a review from a team as a code owner June 23, 2020 08:46
erik-krogh
erik-krogh approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

> var log = console.log;
undefined
> log(2);
2
undefined
>

@esbena esbena mentioned this pull request Jun 23, 2020
Merged
@semmle-qlci semmle-qlci merged commit a723ac0 into github:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erik-krogh erik-krogh erik-krogh approved these changes

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esbena @erik-krogh @semmle-qlci