Skip to content

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jun 23, 2020

No description provided.

@hvitved hvitved requested a review from jbj June 23, 2020 12:49
@dbartol
Copy link

dbartol commented Jun 23, 2020

Are there any common places where users will view QLDoc where target-language highlighting isn't supported, and the target-language specifier is just cluttering things? I know that VSCode supports highlighting. Does the translation to whatever our online help format is handle this? Does it at least strip out the language specifier when it formats as HTML?

As for viewing on GitHub itself, let's try and see:

int main(int argc, const char* const* argv) {
  return 0;
}

💥

@hvitved
Copy link
Contributor Author

hvitved commented Jun 23, 2020

Are there any common places where users will view QLDoc where target-language highlighting isn't supported, and the target-language specifier is just cluttering things? I know that VSCode supports highlighting. Does the translation to whatever our online help format is handle this? Does it at least strip out the language specifier when it formats as HTML?

I tested with this QLDoc (which has been around for 9 months), and it renders fine in our help pages, as well as in the LGTM query console (hover over the unifiable predicate).

@jbj jbj merged commit 3982da5 into github:master Jun 24, 2020
@hvitved hvitved deleted the qldoc-style-tripleticks branch June 24, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants